[ 
https://issues.apache.org/jira/browse/AIRFLOW-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743472#comment-16743472
 ] 

Jarek Potiuk commented on AIRFLOW-3629:
---------------------------------------

As discussed in the PR: [https://github.com/apache/airflow/pull/4538]  - this 
is far too risky change for the benefit, so it's better not to do it just to 
get rid of warnings.

> Not implemented methods in Base Hook
> ------------------------------------
>
>                 Key: AIRFLOW-3629
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3629
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>
> There are four not implemented methods in Base Hook:
>  * get_conn()
>  * get_records()
>  * get_pandas_df()
>  * run(sql)
> They are clearly DB API related but they are in Base Hook and then 
> IDE's/static analysis produces annoying "Abstract Class" warning about all 
> the hooks which do not implement those methods. - it seem that we need 
> another separate abstract class that the DB API-related hooks will derive 
> from.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to