[
https://issues.apache.org/jira/browse/AIRFLOW-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745605#comment-16745605
]
ASF GitHub Bot commented on AIRFLOW-3725:
-----------------------------------------
asawitt commented on pull request #4549: [AIRFLOW-3725] Add private_key to
bigquery_hook get_pandas_df
URL: https://github.com/apache/airflow/pull/4549
[AIRFLOW-3725] Bigquery Hook authentication currently defaults to Google
User-account
credentials, and the user is asked to authenticate with Pandas GBQ
manually. This diff allows users to specify a private_key in either
json or key_path form, in keeping with the Google Cloud Platform
connection type.
### Tests
The following unit tests have been added:
TestPandasGbqPrivateKey.test_key_path_provided
TestPandasGbqPrivateKey.test_key_json_provided
TestPandasGbqPrivateKey.test_no_key_provided
### Code Quality
- [✓] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bigquery_hook should be able to supply private_key to pandas_gbq.read_gbq
> -------------------------------------------------------------------------
>
> Key: AIRFLOW-3725
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3725
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Asa
> Assignee: Asa
> Priority: Minor
>
> Pandas_gbq.read_gbq uses Google application default credentials if a
> private_key is not supplied. We should allow users to pass in this
> private_key in order to allow key-based authentication.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
