mik-laj commented on a change in pull request #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#discussion_r249203936
########## File path: airflow/contrib/operators/aks_operator.py ########## @@ -0,0 +1,200 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from airflow.contrib.hooks.azure_kubernetes_hook import AzureKubernetesServiceHook +from airflow.models import BaseOperator + +from azure.mgmt.containerservice.models import ContainerServiceLinuxProfile +from azure.mgmt.containerservice.models import ContainerServiceServicePrincipalProfile +from azure.mgmt.containerservice.models import ContainerServiceSshConfiguration +from azure.mgmt.containerservice.models import ContainerServiceSshPublicKey +from azure.mgmt.containerservice.models import ContainerServiceStorageProfileTypes +from azure.mgmt.containerservice.models import ManagedCluster +from azure.mgmt.containerservice.models import ManagedClusterAgentPoolProfile + +from airflow.contrib.utils.aks_utils import \ + is_valid_ssh_rsa_public_key, get_poller_result, get_public_key, get_default_dns_prefix +from knack.log import get_logger +from msrestazure.azure_exceptions import CloudError + +logger = get_logger(__name__) Review comment: Please do not use a separate logger. `BaseOperator extends `LoggingMixin`, which has methods for this purpose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
