Fokko commented on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455889389 @potiuk To recap my concern: When having an aggressive caching strategy, the container and the master repository might get out of sync. But before we do this, I think we should: 1. Pin the versions of the dependencies, please refer to: https://lists.apache.org/thread.html/9e775d11cce6a3473cbe31908a17d7840072125be2dff020ff59a441@%3Cdev.airflow.apache.org%3E 2. Make sure that we first always pull the base image. Having `docker build --pull` normally. So we always build from the latest base image. Which also ties in with why you shouldn't do `apt-get upgrade -y` in your docker image as your base image should be up to date: https://serverfault.com/questions/924394/is-it-a-good-practice-to-put-update-upgrade-statements-inside-the-dockerfile/924417 Please don't get me wrong, I'm not against a layered docker image, but I see some problems with the current state of Airflow, where the image might build with the cached version on Airflow's dockerhub, but it won't work when people try to build it locally.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
