mik-laj commented on a change in pull request #4563: [AIRFLOW-2009] Fix
dataflow hook connection-id
URL: https://github.com/apache/airflow/pull/4563#discussion_r249415920
##########
File path: airflow/contrib/hooks/gcp_api_base_hook.py
##########
@@ -24,13 +24,16 @@
import google.auth
import google_auth_httplib2
import google.oauth2.service_account
+import os
+import tempfile
from airflow.exceptions import AirflowException
from airflow.hooks.base_hook import BaseHook
from airflow.utils.log.logging_mixin import LoggingMixin
_DEFAULT_SCOPES = ('https://www.googleapis.com/auth/cloud-platform',)
+G_APP_CRED = "GOOGLE_APPLICATION_CREDENTIALS"
Review comment:
Can you change a constant name? The current name is an abbreviation of the
value, but it does not describe its purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
