ffinfo commented on a change in pull request #4562: [WIP][AIRFLOW-3735] Separated parsing from checking URL: https://github.com/apache/airflow/pull/4562#discussion_r249584006
########## File path: airflow/utils/dag_processing.py ########## @@ -43,16 +46,18 @@ # To avoid circular imports import airflow.models -from airflow import configuration as conf +from airflow import configuration as conf, configuration from airflow.dag.base_dag import BaseDag, BaseDagBag -from airflow.exceptions import AirflowException +from airflow.exceptions import AirflowException, AirflowDagCycleException from airflow.models import errors from airflow.settings import logging_class_path from airflow.utils import timezone from airflow.utils.db import provide_session from airflow.utils.log.logging_mixin import LoggingMixin from airflow.utils.state import State +from airflow.utils.timeout import timeout +_log = logging.root.getChild(__package__) Review comment: Can I also use this when it's not a class? Or should I make a class with just a static method then? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
