[ 
https://issues.apache.org/jira/browse/AIRFLOW-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749407#comment-16749407
 ] 

Daniel Rubenstein commented on AIRFLOW-3753:
--------------------------------------------

On a single search, I found that the GitHub enterprise auth backend also uses 
this - so there is more scope here than I originally anticipated.

I'm going to start with the Google version, and if I find success here, I'll 
keep this issue posted.

Again, let me know if you have comments or concerns.

> Upgrade Google Oauth Backend from Flask Oauthlib to Authlib
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-3753
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3753
>             Project: Apache Airflow
>          Issue Type: Wish
>            Reporter: Daniel Rubenstein
>            Priority: Minor
>
> [Airflow's contributed backed for Google 
> Authentication|https://github.com/apache/airflow/blob/master/airflow/contrib/auth/backends/google_auth.py]
>  relies on the python library [Flask 
> Oauthlib|https://github.com/lepture/flask-oauthlib], and is tied to having a 
> version greater than 0.9.1 ([see 
> setup.py|https://github.com/apache/airflow/blob/master/setup.py#L186]).
> As of March 2018 (see [this 
> update|https://github.com/lepture/flask-oauthlib/commit/7a58b6d48a99a2d3aca4e887a4bb56458fcc6e46#diff-88b99bb28683bd5b7e3a204826ead112]),
>  [Authlib|https://github.com/lepture/authlib] (maintained by the same owner) 
> has been recommended as the replacement.
> Since that time, external changes to Oauth have caused various breaks in 
> builds that are pinned to this version, as Flask-Oauthlib is deprecated at 
> this point and does not receive standard PyPI updates and other maintenance.
> I'm wondering if the maintainers of the project would accept a PR that 
> updates the backend to use the newer library. I'd be happy to take a crack at 
> it, just want to make sure it's something that the community sees as 
> worthwhile before getting started.
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to