ashb commented on a change in pull request #3992: [AIRFLOW-620] Feature to tail
custom number of logs instead of rendering whole log
URL: https://github.com/apache/airflow/pull/3992#discussion_r250558568
##########
File path: airflow/utils/helpers.py
##########
@@ -317,3 +317,45 @@ def render_log_filename(ti, try_number,
filename_template):
task_id=ti.task_id,
execution_date=ti.execution_date.isoformat(),
try_number=try_number)
+
+
+def tail_file(filepath, lines):
Review comment:
I would like to see a test of this function please, at least covering one
happy/working case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
