andyh1203 commented on a change in pull request #4590: [AIRFLOW-3727] Change
references of is_localized to is_aware
URL: https://github.com/apache/airflow/pull/4590#discussion_r251185780
##########
File path: airflow/api/common/experimental/mark_tasks.py
##########
@@ -74,7 +74,7 @@ def set_state(task, execution_date, upstream=False,
downstream=False,
:param session: database session
:return: list of tasks that have been created and updated
"""
- assert timezone.is_localized(execution_date)
+ assert timezone.is_aware(execution_date)
Review comment:
I was thinking by renaming the function to `timezone.is_aware()`, it'd be
more consistent with the corresponding `timezone.make_aware()` function
(similar to how there's `timezone.is_naive()` and `timezone.make_naive()`).
Valid point though that modifying the doc would be much simpler, (I see you've
opened up a PR #4592, so if we want to just modify the docs, we can go ahead
and close this PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
