Fokko commented on issue #2206: [AIRFLOW-922] Update PrestoHook to enable synchronous execution URL: https://github.com/apache/airflow/pull/2206#issuecomment-458524818 It looks like Python2 isn't passing on the tests: ``` ====================================================================== 66) FAIL: test_run_continues_polling_if_execution_status_unknown (tests.hooks.test_presto_hook.TestPrestoHook) ---------------------------------------------------------------------- Traceback (most recent call last): .tox/py27-backend_sqlite-env_docker/lib/python2.7/site-packages/mock/mock.py line 1305 in patched return func(*args, **keywargs) tests/hooks/test_presto_hook.py line 87 in test_run_continues_polling_if_execution_status_unknown mock_sleep.assert_called_once_with(POLL_INTERVAL) .tox/py27-backend_sqlite-env_docker/lib/python2.7/site-packages/mock/mock.py line 947 in assert_called_once_with raise AssertionError(msg) AssertionError: Expected 'sleep' to be called once. Called 0 times. -------------------- >> begin captured stdout << --------------------- [2019-01-24 21:08:46,786] {base_hook.py:83} INFO - Using connection to: id: presto_default. Host: localhost, Port: 3400, Schema: hive, Login: None, Password: None, extra: {} --------------------- >> end captured stdout << ---------------------- -------------------- >> begin captured logging << -------------------- airflow.utils.log.logging_mixin.LoggingMixin: INFO: Using connection to: id: presto_default. Host: localhost, Port: 3400, Schema: hive, Login: None, Password: None, extra: {} --------------------- >> end captured logging << --------------------- ====================================================================== 67) FAIL: test_run_optionally_blocks_while_statement_executes (tests.hooks.test_presto_hook.TestPrestoHook) ---------------------------------------------------------------------- Traceback (most recent call last): .tox/py27-backend_sqlite-env_docker/lib/python2.7/site-packages/mock/mock.py line 1305 in patched return func(*args, **keywargs) tests/hooks/test_presto_hook.py line 74 in test_run_optionally_blocks_while_statement_executes mock_sleep.assert_called_once_with(POLL_INTERVAL) .tox/py27-backend_sqlite-env_docker/lib/python2.7/site-packages/mock/mock.py line 947 in assert_called_once_with raise AssertionError(msg) AssertionError: Expected 'sleep' to be called once. Called 0 times. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
