jgao54 commented on a change in pull request #4595: [AIRFLOW-XXX] Add a doc about fab security URL: https://github.com/apache/airflow/pull/4595#discussion_r252006673
########## File path: docs/fab_security.rst ########## @@ -0,0 +1,63 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + +.. http://www.apache.org/licenses/LICENSE-2.0 + +.. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Airflow UI Security +=================== + +Security of Airflow Webserver UI is handled by Flask AppBuilder (FAB). +Please read its related `security document <http://flask-appbuilder.readthedocs.io/en/latest/security.html>`_ +regarding its security model. + +Default Roles +------------- +Airflow ships with a set of roles by default: Admin, User, Op, Viewer, and Public. +Only ``Admin`` users could configure/alter the permissions for other roles. But it is not recommended +that ``Admin`` users alter these default roles in any way by removing +or adding permissions to them as these roles will be re-synchronized to their original values. Review comment: @XD-DENG My bad, I re-read the lines and I agree with you it is confusing. In my mind I'm making up words on the fly as I read it: "it's not recommended for admin to change **its own permissions**" is what I thought it suggested. But yes, since #4118, permission change will be persisted for other roles. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
