feluelle commented on a change in pull request #4613: [AIRFLOW-3749] Fix Edit
Dag Run page when using RBAC
URL: https://github.com/apache/airflow/pull/4613#discussion_r252585898
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -521,7 +521,7 @@ <h4 class="modal-title" id="dagModalLabel">
});
$('#btn_edit_dagrun').click(function() {
- window.location = "{{ url_for('DagModelView.show', pk=dag.dag_id) }}";
+ window.location = "{{ url_for('DagModelView.edit', pk=dag.dag_id) }}";
Review comment:
The advantage of using `url_for('DagModelView.show', pk=dag.dag_id)` is that
we don't have to worry about the url generation and if flask, for some reason,
changes this url from `/dagmodel/show/<pk>` to `/dagmodel/show?<pk>` we do not
need to change anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
