[
https://issues.apache.org/jira/browse/AIRFLOW-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759336#comment-16759336
]
ASF GitHub Bot commented on AIRFLOW-3801:
-----------------------------------------
Patouche commented on pull request #4645: [AIRFLOW-3801] Fix DagBag collect
dags invocation to prevent examples…
URL: https://github.com/apache/airflow/pull/4645
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-3801) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-3801
### Description
- Fix in DagBag init method the`include_examples` parameters which was not
use properly.
### Tests
- [X] tests.models.DagBagTest#test_dont_load_example : When the parameter
`include_examples` is set to false on a empty dags folder, this validate that
the dagbag is empty.
### Documentation
- N/A
### Code Quality
- [X] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DagBag always import examples
> ------------------------------
>
> Key: AIRFLOW-3801
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3801
> Project: Apache Airflow
> Issue Type: Bug
> Components: models
> Affects Versions: 1.10.2, 2.0.0
> Reporter: Patrick Allain
> Priority: Minor
> Fix For: 1.10.3
>
>
> Hello,
> Yesterday, I notice in my unit test that the example was always loaded even
> if I explicitly specified the parameters {{include_examples=False}} in the
> {{DagBag}} constructor.
> In fact, the DagBag init method invoke the {{collect_dags}} method without
> naming the parameters. Inside, the {{collect_dags}} method, the method
> {{list_py_file_paths}} was invoke without naming the parameters also.
> I tried to fix it in a pull request that will be made very soon.
>
> Regards,
> Patrick
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
