skudriashev commented on a change in pull request #4651: [AIRFLOW-XXX] Add 
exception details to warning log
URL: https://github.com/apache/airflow/pull/4651#discussion_r253727191
 
 

 ##########
 File path: airflow/settings.py
 ##########
 @@ -80,8 +80,8 @@ def timing(cls, stat, dt):
             port=conf.getint('scheduler', 'statsd_port'),
             prefix=conf.get('scheduler', 'statsd_prefix'))
         Stats = statsd
-except (socket.gaierror, ImportError):
-    log.warning("Could not configure StatsClient, using DummyStatsLogger 
instead.")
+except (socket.gaierror, ImportError) as e:
+    log.warning("Could not configure StatsClient: ", e, ", using 
DummyStatsLogger instead.")
 
 Review comment:
   This is not what you want I guess:
   
   ```
   log.warning("Could not configure StatsClient: %s, using DummyStatsLogger 
instead.", e)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to