[ 
https://issues.apache.org/jira/browse/AIRFLOW-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762243#comment-16762243
 ] 

ASF GitHub Bot commented on AIRFLOW-3817:
-----------------------------------------

mans2singh commented on pull request #4659: AIRFLOW-3817 - Corrected ids 
returned by BranchPythonOperator in example
URL: https://github.com/apache/airflow/pull/4659
 
 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/AIRFLOW-3817) issues and 
references them in the PR title. "
     - https://issues.apache.org/jira/browse/AIRFLOW-3817
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:  Correct task ids returned by BranchPythonOperator in the examples.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:  The change is only in the example dag.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Correct task ids returned by the BranchPythonOperator processor for 
> example_branch_python_dop_operator_3
> --------------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3817
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3817
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: examples
>    Affects Versions: 1.10.2
>            Reporter: Mans Singh
>            Assignee: Mans Singh
>            Priority: Minor
>             Fix For: 1.10.3
>
>
> The BranchPythonOperator in the example_branch_python_dop_operator_3, returns 
> oper_1 or oper_2 but the downstream dummy operators have ids dummy_task_1 and 
> dummy_task_2.   So, they will always be skipped. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to