ashb commented on a change in pull request #4640: [RFC] [WIP] Feature/flask
restful
URL: https://github.com/apache/airflow/pull/4640#discussion_r255073955
##########
File path: airflow/plugins_manager.py
##########
@@ -84,12 +84,16 @@ def load_entrypoint_plugins(entry_points, airflow_plugins):
:type airflow_plugins: List[AirflowPlugin]
:return: List[Type[AirflowPlugin]]
"""
+ from airflow.www.app import app
for entry_point in entry_points:
log.debug('Importing entry_point plugin %s', entry_point.name)
plugin_obj = entry_point.load()
if is_valid_plugin(plugin_obj, airflow_plugins):
if callable(getattr(plugin_obj, 'on_load', None)):
- plugin_obj.on_load()
+ plugin_obj.on_load(
+ flask_app=app,
+ configuration=configuration
Review comment:
Does this count as a breaking change? (I can't remember when we added this
method.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
