XD-DENG commented on issue #4673: [AIRFLOW-3851] ExternalTasksensor not check existence in later poke URL: https://github.com/apache/airflow/pull/4673#issuecomment-462024314 @feng-tao I was just referring to a possible situation, even thought it's rare. The dependency among DAGs is not maintained in DB, so checking whether a DAG is depended by another one before removing/modifying it is hard to do. If we're checking from a "trading-off" perspective, I would agree with your point, and this PR LGTM. My another suggestion is really nit: `has_checked_existence` may be better than `has_check_existence`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
