mik-laj commented on a change in pull request #4341: [AIRFLOW-3537] Add
task_definition as templated parameter in AWS ECS Operator
URL: https://github.com/apache/airflow/pull/4341#discussion_r255361345
##########
File path: tests/contrib/operators/test_ecs_operator.py
##########
@@ -95,7 +95,7 @@ def test_init(self):
self.aws_hook_mock.assert_called_once_with(aws_conn_id=None)
def test_template_fields_overrides(self):
- self.assertEqual(self.ecs.template_fields, ('overrides',))
Review comment:
This is a senseless test. Tests should check behavior, not field values.
It's better to write something like:
https://github.com/apache/airflow/blob/master/tests/contrib/operators/test_gcp_compute_operator.py#L73-L98
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
