[ 
https://issues.apache.org/jira/browse/AIRFLOW-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764904#comment-16764904
 ] 

Ash Berlin-Taylor commented on AIRFLOW-3742:
--------------------------------------------

the built-in {{int()}} method throws an exception already:
{code:java}
% python -c 'int("abc")'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ValueError: invalid literal for int() with base 10: 'abc'{code}
I don't think we need any extra tests given that do we?

> airflow.configuration doesn't respect fallback kwarg
> ----------------------------------------------------
>
>                 Key: AIRFLOW-3742
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3742
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: configuration
>            Reporter: Ash Berlin-Taylor
>            Assignee: Ash Berlin-Taylor
>            Priority: Minor
>             Fix For: 1.10.3
>
>
> The ConfigParser class we base our config parser on can optionally accept a 
> fallback argument:
> {code:python}
> conf.get('sect', 'key', fallback='default')
> {code}
> but our sub-class doesn't support this. It would be nice if we did. Then we 
> can turn
> {code:python}
> plugins_folder = configuration.conf.get('core', 'plugins_folder')
> if not plugins_folder:
>     plugins_folder = settings.AIRFLOW_HOME + '/plugins'
> {code}
> in to this:
> {code:python}
> plugins_folder = configuration.conf.get('core', 'plugins_folder', 
> fallback=settings.AIRFLOW_HOME + '/plugins')
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to