[
https://issues.apache.org/jira/browse/AIRFLOW-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765718#comment-16765718
]
ASF GitHub Bot commented on AIRFLOW-3874:
-----------------------------------------
ryanyuan commented on pull request #4695: [AIRFLOW-3874] Improve
BigQueryHook.run_with_configuration's location support
URL: https://github.com/apache/airflow/pull/4695
In BigQueryHook.run_with_configuration, after inserting new job and get the
resp of the job details, it should retrieve the location and use it for the
jobs.get request.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following
[Airflow-3874](https://issues.apache.org/jira/browse/AIRFLOW-3874) issues and
references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
test_bigquery_hook.py::TestBigQueryHookRunWithConfiguration
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve BigQueryHook.run_with_configuration's location support
> --------------------------------------------------------------
>
> Key: AIRFLOW-3874
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3874
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Ryan Yuan
> Assignee: Ryan Yuan
> Priority: Major
>
> BigQueryHook.run_with_configuration creates a new job and receives a response
> with location field. It should use that field for the keep_polling_job loop.
> Otherwise, it returns 404 job not found if the location is not US or EU.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
