[
https://issues.apache.org/jira/browse/AIRFLOW-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768610#comment-16768610
]
ASF GitHub Bot commented on AIRFLOW-3619:
-----------------------------------------
holdenk commented on pull request #4710: [AIRFLOW-3619] Improve flake8 excludes
without excluding requirements.
URL: https://github.com/apache/airflow/pull/4710
## Jira
- [ X ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ X ] Here are some details about my PR, including screenshots of any UI
changes:
Update the flake8 excludes
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Test plan:
1) Create new flake8 excludes (pass CI)
2) Create a style violation (fail CI in branch)
3) Fix style violation (pass CI in branch)
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> flake8 excludes
> ---------------
>
> Key: AIRFLOW-3619
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3619
> Project: Apache Airflow
> Issue Type: Improvement
> Components: tests
> Reporter: holdenk
> Assignee: holdenk
> Priority: Trivial
>
> The flake8 excludes I added in AIRFLOW-3558 were too broad and had to be
> reverted in AIRFLOW-3606.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
