astahlman commented on a change in pull request #4396: [AIRFLOW-3585] - Add
edges to database
URL: https://github.com/apache/airflow/pull/4396#discussion_r257101516
##########
File path: tests/core.py
##########
@@ -166,6 +176,7 @@ def test_schedule_dag_relativedelta(self):
task_id="faketastic",
owner='Also fake',
start_date=datetime(2015, 1, 2, 0, 0)))
+ dag.sync_to_db()
Review comment:
Maybe a dumb question, but it's not clear to me why we need all of these new
calls to `sync_to_db()` scattered throughout the tests (or how you identified
all of the spots where we need to sync). Can you elaborate on the impact of
*not* explicitly syncing the DagModel?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
