[
https://issues.apache.org/jira/browse/AIRFLOW-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768938#comment-16768938
]
ASF GitHub Bot commented on AIRFLOW-3887:
-----------------------------------------
astahlman commented on pull request #4713: [AIRFLOW-3887] Downgrade dagre-d3 to
0.4.18
URL: https://github.com/apache/airflow/pull/4713
Make sure you have checked _all_ steps below.
### Jira
- [ X ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3887
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ X ] Here are some details about my PR, including screenshots of any UI
changes:
dagre-d3 v0.6.3 has a bug that causes this Javascript error when loading
the Graph View:
TypeError: previousPaths.merge is not a function
The bug fix [1] has been merged to master, but hasn't been released to
npm yet. This change temporarily downgrades our version of dagre-d3
until dagre-d3 v0.6.4 is released [2]
I also fixed a bug I encountered in the `compile_assets.sh` where the
script would fail if the directory `airflow/www/static/dist/` exists but
is empty.
[1] https://github.com/dagrejs/dagre-d3/pull/350
[2]
https://github.com/dagrejs/dagre-d3/blob/5450627790ff42012ef50cef6b0e220199ae4fbe/package.json#L3
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ X ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ X ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Dagre D3 Version 0.6.3 raises merge is not a function error
> -----------------------------------------------------------
>
> Key: AIRFLOW-3887
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3887
> Project: Apache Airflow
> Issue Type: Bug
> Affects Versions: 1.10.2
> Reporter: Felix Uellendall
> Priority: Major
> Attachments: Screen Shot 2019-02-06 at 16.13.05.png
>
>
> The latest version of Dagre D3 that we already use (0.6.3) contains a bug
> that causes the Graph View to stop working for D3 Version 3 that we are using.
> {noformat}
> TypeError: previousPaths.merge is not a function
> {noformat}
> !Screen Shot 2019-02-06 at 16.13.05.png!
> To temporary fix this you can pin your Dagre D3 version to 0.4.18
> The actual fix should be to set Dagre D3 to the next release that contains
> this bugfix.
> See: https://github.com/dagrejs/dagre-d3/pull/350
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
