ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges
to database
URL: https://github.com/apache/airflow/pull/4396#discussion_r257131721
##########
File path: airflow/models/__init__.py
##########
@@ -688,6 +632,57 @@ def __init__(self, task, execution_date, state=None):
# Not persisted to the database so only valid for the current process
self.raw = False
+ @staticmethod
Review comment:
mainly because it never uses `self` methods. Now the method can be used with
a instance of TaskInstance itself. Makes more sense because this method does
multiple TaskInstances and not only the instance where you calling the method on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
