[ 
https://issues.apache.org/jira/browse/AIRFLOW-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769339#comment-16769339
 ] 

ASF GitHub Bot commented on AIRFLOW-3895:
-----------------------------------------

judoole commented on pull request #4717: [AIRFLOW-3895] GoogleCloudStorageHook 
create_bucket with optional request body
URL: https://github.com/apache/airflow/pull/4717
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   When creating a new bucket in Google Cloud Storage, 
GoogleCloudStorageHook.create_bucket, I would like to have the option of 
supplying missing parameters.
   
   For instance, the field 
[lifecycle](https://cloud.google.com/storage/docs/json_api/v1/buckets#lifecycle)
 is not available. 
   
   My suggestion to supply this is to add an optional dict to the parameters 
that gets overwritten with bucket_name, storage_class and collection.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   - Updates `GoogleCloudStorageCreateBucketTest` with `resource` param
   - Was not able to figure out how to write a test for 
`GoogleCloudStorageHook.create_bucket`
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GoogleCloudStorageHook.create_bucket with optional request body
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-3895
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3895
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>    Affects Versions: 1.10.2
>            Reporter: Ole Christian Langfjæran
>            Priority: Trivial
>
> When creating a new bucket in Google Cloud Storage, 
> GoogleCloudStorageHook.create_bucket, I would like to have the option of 
> supplying missing parameters.
> For instance, the field 
> [lifecycle|https://cloud.google.com/storage/docs/json_api/v1/buckets#lifecycle]
>  is not available. 
> My suggestion to supply this is to add an optional dict to the parameters 
> that gets overwritten with bucket_name, storage_class and collection.
> For example like so:
> {{def create_bucket(self,}}
> {{     bucket_name,}}
> {{     resource=None,}}
> {{     storage_class='MULTI_REGIONAL',}}
> {{     location='US',}}
> {{     project_id=None,}}
> {{     labels=None):}}
> ....
> {{     service = self.get_conn()}}
> {{     bucket_resource = copy.copy(resource)}}
> {{     bucket_resource.update({}}
> {{          'name': bucket_name,}}
> {{          'location': location,}}
> {{          'storageClass': storage_class}}
> {{     })}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to