[
https://issues.apache.org/jira/browse/AIRFLOW-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771291#comment-16771291
]
ASF GitHub Bot commented on AIRFLOW-3885:
-----------------------------------------
astahlman commented on pull request #4730: [WIP] [AIRFLOW-3885] ~10x speed-up
of SchedulerJobTest suite
URL: https://github.com/apache/airflow/pull/4730
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3885
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ X ] Here are some details about my PR, including screenshots of any UI
changes:
The SchedulerJobTest suite now takes ~90 seconds on my laptop (down from
~900 seconds == 15 minutes) on Jenkins.
There are a few optimizations here:
1. Don't sleep() for 1 second every scheduling loop (in unit tests)
2. Don't process the example DAGs
3. Use `subdir` to process only the DAGs we need, for a couple of tests
that actually run the scheduler
4. Only load the DagBag once instead of before each test
I've also added a few tables to the list of tables that are cleaned up
in between test runs to make the tests re-entrant.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ X ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ X ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve Travis buildtime
> ------------------------
>
> Key: AIRFLOW-3885
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3885
> Project: Apache Airflow
> Issue Type: Bug
> Components: travis
> Affects Versions: 1.10.2
> Reporter: Drew Sonne
> Assignee: Drew Sonne
> Priority: Major
> Fix For: 1.10.3
>
>
> * Remove the "install" action on the "pre-test" stage to avoid performing
> lengthy Docker pulls to perform pre-checks
> * Set nosetests to return on any test failures
> ** Given the lengthy runtime of the airflow CI test suites, if any tests
> fail, we should fail immediately and return the failed test locally. Users
> can run the tests locally to get full lists of failed tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
