ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-465554935
 
 
   @feng-tao: I do understand your concerns, I'm also happy to look into issues 
en look at solutions.
    Although I must say giving a `-1` is a bit demotivating. I do not give up 
yet ;).
   
   @feng-tao @astahlman:
   I did manage to fix the issue in the migration step, see also:
   
https://github.com/apache/airflow/pull/4396/commits/cc2df2469b4ac00cebbb86e4ffbe35949353914b
   It does required to use `airflow upgradedb`. Of course this is true for any 
version upgrade so this should be be a blocker.
   
   The 'big' button I did remove. The error about historical runs is gone. This 
way the user almost don't see any difference between before this PR. Only thing 
that the user will is the message when there is no DagRun yet: `This is showing 
the dag parsed from the DAG file. This is not an active DagRun`.
   
   Can you try this again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to