XD-DENG opened a new pull request #4752: [AIRFLOW-3935] answer a TODO in 
airflow/executors/local_executor.py
URL: https://github.com/apache/airflow/pull/4752
 
 
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3935
   
   
   ### Description
   
   The TODO cleared in this PR actually was asking a question, why 'raise e' 
was commented.
   
   To answer why 'raise e' was commented:
   1. This `try-except` is inside method `execute_work()` & there are other 
operations after the try-except as well as after invoking this method. Raising 
exception here will prevent all following steps from taking place properly.
   2. The exception itself is already marked properly by labelling state to be 
FAILED, and the exception is printed out using `self.log.error()`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to