ashb commented on a change in pull request #4745: [AIRFLOW-xxx] Correct
BranchPythonOperator docs
URL: https://github.com/apache/airflow/pull/4745#discussion_r259269770
##########
File path: airflow/operators/python_operator.py
##########
@@ -132,10 +132,8 @@ class BranchPythonOperator(PythonOperator, SkipMixin):
to be inferred.
Note that using tasks with ``depends_on_past=True`` downstream from
- ``BranchPythonOperator`` is logically unsound as ``skipped`` status
- will invariably lead to block tasks that depend on their past successes.
- ``skipped`` states propagates where all directly upstream tasks are
- ``skipped``.
+ ``BranchPythonOperator`` is fine because depends_on_past allows for
+ past tasks to be skipped.
Review comment:
Lets just remove the paragraph entirely if this is the case? (Since when was
this the case?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
