ashb commented on a change in pull request #4705: [AIRFLOW-3743] Unify
different methods of working out AIRFLOW_HOME
URL: https://github.com/apache/airflow/pull/4705#discussion_r259293780
##########
File path: airflow/configuration.py
##########
@@ -530,6 +530,24 @@ def parameterized_config(template):
conf.read(AIRFLOW_CONFIG)
+if conf.has_option('core', 'AIRFLOW_HOME'):
+ if 'AIRFLOW_HOME' in os.environ:
+ warnings.warn(
+ 'Specifying both AIRFLOW_HOME environment variable and
airflow_home '
+ 'in the config file is deprecated. Please use only the
AIRFLOW_HOME '
+ 'environment variable and remove the config file entry.',
+ category=DeprecationWarning,
+ )
+ else:
+ AIRFLOW_HOME = conf.get('core', 'airflow_home')
Review comment:
Throwing an exception in this case would be a breaking change (as this was
in the default template, so every install would and up stopping working) which
I am trying to avoid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
