ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges
to database
URL: https://github.com/apache/airflow/pull/4396#discussion_r259609953
##########
File path: airflow/www/views.py
##########
@@ -1293,50 +1302,72 @@ def set_duration(tid):
def graph(self, session=None):
dag_id = request.args.get('dag_id')
blur = conf.getboolean('webserver', 'demo_mode')
- dag = dagbag.get_dag(dag_id)
- if dag_id not in dagbag.dags:
- flash('DAG "{0}" seems to be missing.'.format(dag_id), "error")
- return redirect('/')
-
root = request.args.get('root')
+ read_from_file = request.args.get('read_from_file')
Review comment:
The button is gone but the functionality is still in there as hidden
argument. This is used at the point there is not a dag run yet for a dag. In
this case flask will redirect to `/graph?dag_id=dag_name&read_from_file=True`.
This has no harm on the user because they don't even know this happens ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
