dmateusp opened a new pull request #4777: Airflow 3918 add git sync ssh auth
URL: https://github.com/apache/airflow/pull/4777
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   > - [X] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
   >  - https://issues.apache.org/jira/browse/AIRFLOW-XXX
   >  - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   https://issues.apache.org/jira/browse/AIRFLOW-3918
   
   ### Description
   
   > - [X] Here are some details about my PR, including screenshots of any UI 
changes:
   
   This PR adds support for Git Sync authentication through SSH key (e.g. a 
GitHub deployment read-only key)
   
   ### Tests
   
   > - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   * test_worker_configuration_auth_both_ssh_and_user: tests that configuration 
validation throws an exception when both user authentication and SSH 
authentication are configured
   * test_init_environment_using_git_sync_ssh: tests that the environment is 
correctly set up for the init pod when using SSH auth
   * test_make_pod_git_sync_ssh: tests that the make_pod function correctly 
generates the config for the pod, covers security_context test
   
   Additionally tested at HBC on our cluster
   
   ### Commits
   
   > - [X] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   >  1. Subject is separated from body by a blank line
   >  1. Subject is limited to 50 characters (not including Jira issue 
reference)
   >  1. Subject does not end with a period
   >  1. Subject uses the imperative mood ("add", not "adding")
   >  1. Body wraps at 72 characters
   >  1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   > - [X] In case of new functionality, my PR adds documentation that 
describes how to use it.
   >  - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
   >  - All the public functions and the classes in the PR contain docstrings 
that explain what it does
   
   ### Code Quality
   
   > - [X] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to