[jira] [Commented] (AIRFLOW-3970) Misleading navigation on the DAG screen.

Wed, 27 Feb 2019 06:24:28 -0800 


    [ 
https://issues.apache.org/jira/browse/AIRFLOW-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779355#comment-16779355
 ] 

ASF GitHub Bot commented on AIRFLOW-3970:
-----------------------------------------

mik-laj commented on pull request #4796: [AIRFLOW-3970] Pull out the action 
buttons from the tabs
URL: https://github.com/apache/airflow/pull/4796
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3970
   
   ### Description
   
   Assigning actions to a bookmark element is misleading.Now, bookmarks are 
used only for browsing and  buttons are used to perform action.
   
   Before:
   ![localhost_8004_tree_dag_id example_gcp_vision 
1](https://user-images.githubusercontent.com/12058428/53496242-e81ef780-3aa1-11e9-8082-4d57463e135a.png)
   
   After:
   ![localhost_8004_tree_dag_id 
example_gcp_vision](https://user-images.githubusercontent.com/12058428/53496105-9aa28a80-3aa1-11e9-87c1-3574b0f4badc.png)
   
   @ashb Can you look at it?
   
   ### Tests
   
   No applicable
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Misleading navigation on the DAG screen.
> ----------------------------------------
>
>                 Key: AIRFLOW-3970
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3970
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Kamil Bregula
>            Assignee: Kamil Bregula
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to