jmcarp commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r261225588
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -350,7 +360,7 @@ <h2>DAGs</h2>
})
.on('click', function(d, i) {
if (d.count > 0)
- window.location = "{{ url_for('DagRunModelView.list')
}}?_flt_3_dag_id=" + d.dag_id + "&_flt_3_state=" + d.state;
+ window.location = BASE_URL_DAG_RUN_LIST +
"$?_flt_3_dag_id=" + d.dag_id + "&_flt_3_state=" + d.state;
Review comment:
Can dag ids contain characters that need to be url-encoded? Might be safer
to build query strings with `$.param` or similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
