XD-DENG commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r261239720
########## File path: airflow/contrib/operators/azure_container_instances_operator.py ########## @@ -18,6 +18,9 @@ # under the License. from time import sleep +from collections import namedtuple + +from typing import Dict, Sequence Review comment: Frankly I'm not very familiar with `mypy`, so can not give useful comment here. A minor question here: why the packages are not imported in alphabetic order? And given `typing` is a standard library since Py3.5, we can group these three (`collections`, `time`, `typing`) together? Reference: https://github.com/reddit-archive/reddit/wiki/PythonImportGuidelines ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
