RosterIn commented on a change in pull request #4802: [AIRFLOW-3978] - Add
TIME, BINARY, VARBINARY to MySqlToGoogleCloudStorageOperator
URL: https://github.com/apache/airflow/pull/4802#discussion_r261252434
##########
File path: airflow/contrib/operators/mysql_to_gcs.py
##########
@@ -273,6 +273,8 @@ def type_map(cls, mysql_type):
d = {
FIELD_TYPE.INT24: 'INTEGER',
FIELD_TYPE.TINY: 'INTEGER',
+ FIELD_TYPE.BINARY: 'BINARY',
+ FIELD_TYPE.VARBINARY: 'BINARY',
Review comment:
@XD-DENG
:( I didn't know what package Airflow uses.
These types are in my production table.
They are not new in fact they are ancient from 2011 and earlier
https://dev.mysql.com/doc/refman/5.7/en/binary-varbinary.html
Maybe Airflow should consider working with another package if it doesn't
support something that fundamental?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
