ashb commented on a change in pull request #4675: [AIRFLOW-3853] Default to
delete local logs after remote upload
URL: https://github.com/apache/airflow/pull/4675#discussion_r261358807
##########
File path: tests/utils/log/test_s3_task_handler.py
##########
@@ -136,7 +138,8 @@ def test_read_raises_return_error(self):
def test_write(self):
with mock.patch.object(self.s3_task_handler.log, 'error') as
mock_error:
- self.s3_task_handler.s3_write('text', self.remote_log_location)
+ successful_write = self.s3_task_handler.s3_write('text',
self.remote_log_location)
+ assert successful_write is True
Review comment:
```suggestion
self.assertTrue(successful_write)
```
That way if it isn't we get better error diagnostics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
