ashb commented on a change in pull request #4777: Airflow 3918 add git sync ssh 
auth
URL: https://github.com/apache/airflow/pull/4777#discussion_r261552483
 
 

 ##########
 File path: airflow/contrib/kubernetes/worker_configuration.py
 ##########
 @@ -213,8 +281,7 @@ def generate_dag_volume_mount_path(self):
     def make_pod(self, namespace, worker_uuid, pod_id, dag_id, task_id, 
execution_date,
                  try_number, airflow_command, kube_executor_config):
         volumes_dict, volume_mounts_dict = self.init_volumes_and_mounts()
 
 Review comment:
   Can we rename this? The `init_` prefix on it is confusing me with 
`init_containers` - and I think now these volumes/mounts have nothing to do 
with the init_container, correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to