[
https://issues.apache.org/jira/browse/AIRFLOW-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782524#comment-16782524
]
ASF GitHub Bot commented on AIRFLOW-3998:
-----------------------------------------
jmcarp commented on pull request #4821: [AIRFLOW-3998] Use nested commands in
cli.
URL: https://github.com/apache/airflow/pull/4821
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3998
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement
Proposal([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This is a proof of concept for
https://issues.apache.org/jira/browse/AIRFLOW-3998 /
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-16%3A+Use+nested+commands+in+CLI.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use nested commands in cli
> --------------------------
>
> Key: AIRFLOW-3998
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3998
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Josh Carp
> Assignee: Josh Carp
> Priority: Minor
>
> From
> https://lists.apache.org/thread.html/94c97ed621706a2e9130a3550b879a5838c23209f2d6d40f8bb49cd8@%3Cdev.airflow.apache.org%3E:
>
> The CLI treats `airflow connection` as a single command, with `--list`,
> `--add`, etc. as flags. This means it's possible to pass options that can't
> be used together: passing `--list` with `--conn_id` should be invalid. The
> current implementation has to handle validation of mutually exclusive options
> separately for each command. I think the code would be simpler and easier to
> use if we used nested commands instead of flags: `airflow connections list`
> and `airflow connections add` would be separate subcommands that would take
> different arguments, and we wouldn't have to check for invalid combinations
> of commands and arguments.
>
> I'll file a proof of concept patch refactoring the `airflow connections`
> command for discussion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
