[
https://issues.apache.org/jira/browse/AIRFLOW-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782566#comment-16782566
]
ASF GitHub Bot commented on AIRFLOW-3999:
-----------------------------------------
mik-laj commented on pull request #4823: [AIRFLOW-3999] Remove all inline style
URL: https://github.com/apache/airflow/pull/4823
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement
Proposal([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
### Description
Visual compare available: https://imgur.com/a/ZleMSBP
This PR also introduces other changes:
* support for SCSS. Useful to generate several helper classes and to
generate classes for states.
* change the shade of red to less bright.
* Introduces hover status support for the state button.
* some spaces have been changed to harmonize.
@ashb
### Tests
I did manual tests to compare the changes visually, but also generated
automatic comparisons.
Visual compare available: https://imgur.com/a/ZleMSBP
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
No applicable
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Inline style in HTML
> --------------------
>
> Key: AIRFLOW-3999
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3999
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Kamil Bregula
> Priority: Major
>
> Styles in the HTML code are not seen as good programming practice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
