mik-laj commented on a change in pull request #4792: [AIRFLOW-3659] Create
Google Cloud Transfer Service Operators
URL: https://github.com/apache/airflow/pull/4792#discussion_r261883966
##########
File path: airflow/contrib/hooks/gcp_api_base_hook.py
##########
@@ -188,6 +190,21 @@ def inner_wrapper(self, *args, **kwargs):
fallback_to_default_project_id =
staticmethod(fallback_to_default_project_id)
+ @staticmethod
+ def catch_http_exception(func):
Review comment:
I found one more small difference. If you throw an AirflowException
exception and the task has been marked externally as success/failed, executing
is considered to be successfully completed - no log entry, etc.
Reference:
https://github.com/apache/airflow/blob/0982715a61653d21ac5ff9c1cc26e456ff713607/airflow/models/__init__.py#L1415-L1420
https://github.com/apache/airflow/commit/284dbdb60ab1fec027dea4871e3013a4727f6041
https://github.com/apache/airflow/commit/b2e1753f5b74ad1b6e0889f7b784ce69623c95ce
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
