PaulW edited a comment on issue #4636: [AIRFLOW-3737] Kubernetes executor cannot handle long dag/task names URL: https://github.com/apache/airflow/pull/4636#issuecomment-469216435 Updated the patch. In regards to hashing the label, I've decided it would be good practice to hash the label value if either condition is met: Value Length > 63chars Label is modified as per regex in any way (regardless of length). This way, if the difference between multiple dags or tasks is a character which is not allowed in the label value, and trimming this causes the label to match other dags which would otherwise be unique, this could cause to confusion or certain dags/tasks being marked incorrectly. As long as we append the label with a unique hash generated from the unmodified label value, then we mitigate this condition & should be safe.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
