OmerJog commented on a change in pull request #4811: [AIRFLOW-3984] Add tests
for WinRMHook
URL: https://github.com/apache/airflow/pull/4811#discussion_r262103479
##########
File path: airflow/contrib/hooks/winrm_hook.py
##########
@@ -32,21 +32,18 @@ class WinRMHook(BaseHook):
:seealso: https://github.com/diyan/pywinrm/blob/master/winrm/protocol.py
- :param ssh_conn_id: connection id from airflow Connections from where all
- the required parameters can be fetched like username and password.
+ :param ssh_conn_id: connection id from airflow Connections from where
+ all the required parameters can be fetched like username and password.
Thought the priority is given to the param passed during init
:type ssh_conn_id: str
:param endpoint: When set to `None`, endpoint will be constructed like
this:
'http://{remote_host}:{remote_port}/wsman'
:type endpoint: str
- :param remote_host: Remote host to connect to.
- Ignored if `endpoint` is not `None`.
+ :param remote_host: Remote host to connect to. Ignored if `endpoint` is
not `None`.
Review comment:
It's a bit unclear if you mean None value or string that contains None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
