davlum commented on a change in pull request #4627: [AIRFLOW-3258] K8S executor, optional mount current env in worker pods URL: https://github.com/apache/airflow/pull/4627#discussion_r262164130
########## File path: airflow/config_templates/default_airflow.cfg ########## @@ -610,6 +610,10 @@ worker_pods_creation_batch_size = 1 # The Kubernetes namespace where airflow workers should be created. Defaults to `default` namespace = default +# If True (default False), any worker pods brought up will have the same environment variables as the container +# that created them. These can be overwritten by kubernetes secrets and environment variables. +mount_current_environment = False Review comment: I've definitely considered the possibility that it could cause problems, but I haven't been able to come up with examples of when this could happen. The main problem that this is addressing is that my scheduler and worker pods have the same configuration, and manually specifying environment variables in my deployment file and then again in the `airflow.cfg` is error prone. An alternative might be to specify a ConfigMap that the worker pods `envFrom` in the `airflow.cfg` that could act as a shared resource for the scheduler and worker pods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
