dmateusp commented on a change in pull request #4627: [AIRFLOW-3258] K8S executor, optional mount current env in worker pods URL: https://github.com/apache/airflow/pull/4627#discussion_r262171200
########## File path: airflow/config_templates/default_airflow.cfg ########## @@ -610,6 +610,10 @@ worker_pods_creation_batch_size = 1 # The Kubernetes namespace where airflow workers should be created. Defaults to `default` namespace = default +# If True (default False), any worker pods brought up will have the same environment variables as the container +# that created them. These can be overwritten by kubernetes secrets and environment variables. +mount_current_environment = False Review comment: What you're saying makes sense, if more people agree that this won't cause issues I'd be fine with it, I like the idea of sharing a Configmap instead maybe you could change the configuration to be something like ``` # --- # airflow-configmap.yaml: # apiVersion: v1 # kind: ConfigMap # metadata: # name: airflow-configmap # data: # worker.env: | # ... worker-env-from-configmap = airflow-configmap ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
