ashb commented on a change in pull request #4543: [AIRFLOW-3718] [WIP]
Multi-layered version of the docker image
URL: https://github.com/apache/airflow/pull/4543#discussion_r262449409
##########
File path: scripts/ci/kubernetes/docker/build.sh
##########
@@ -34,7 +34,7 @@ fi
echo "Airflow directory $AIRFLOW_ROOT"
echo "Airflow Docker directory $DIRNAME"
-if [[ ${PYTHON_VERSION} == '3' ]]; then
+if [[ ${PYTHON_VERSION} == 3* ]]; then
Review comment:
One interesting thing on 3.5 vs 3.6 that I noticed - It's probably worth
testing against 3.5.2 explicitly as that is the version of Python3 on Ubuntu
16.04 (and maybe 18.04 too?) - one of our downstream deps had an issue with
3.5.2, so testing that explicitly makes sense as it's a common deployment
target.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
