ashb commented on issue #4642: [AIRFLOW-2694] Declare permissions in DAG definition URL: https://github.com/apache/airflow/pull/4642#issuecomment-469736358 Is there a reason we don't (additionally) sync the DAG parms at webserver start up? I had to dig in to the code to find why my dag perms weren't being written to the DB - I assumed that if we changed them then the webserver would pick them up when the scheduler procesed the DAG. Something about the current approach doesn't quite sit with me (I think the scheduler should be doing the updating automatically) but I don't really want the scheduler to have to know about the FAB tables. How about something like this: - We add a column/columns to the Dag table (`can_edit_roles`, `can_read_roles`) and the scheduler updates that - Update security manger to look in there when checking the `can_dag_*` permissions instead of AB's own role<->perm mapping? Dunno. This was unexpected is all.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
