feng-tao commented on issue #4569: [AIRFLOW-3745] Fix viewer not able to view 
dag details
URL: https://github.com/apache/airflow/pull/4569#issuecomment-469817956
 
 
   @ashb , let's consolidate all the discussion in one place. And I could do 
some investigations in my night time(PST time zone). From what I understanding, 
your issues are:
   1. you couldn't pause DAG with op 
role(https://github.com/apache/airflow/blob/master/airflow/www/views.py#L1657) 
? Have you checked whether the refactored UI could pass the `is_paused` param 
to Flask? For pause, I am pretty sure it is not related to this pr.
   2. your comment in 
https://github.com/apache/airflow/pull/4118#issuecomment-469801650 which 
all_dags permissions not shown until roles created.  The latest version in 
master has changed which create the all_dag view-menu when the webserver 
starts(https://github.com/apache/airflow/blob/master/airflow/www/security.py#L460).
 And one thing we could do with 
https://github.com/apache/airflow/pull/4118/files is to make sure all_dags 
permissions are always exist in the existing roles which means user could only 
remove non dag permissions. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to