[ 
https://issues.apache.org/jira/browse/AIRFLOW-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785774#comment-16785774
 ] 

ASF GitHub Bot commented on AIRFLOW-4028:
-----------------------------------------

XD-DENG commented on pull request #4856: [AIRFLOW-4028] Avoid Adding DAG_PERMS 
of All DAGs to Admin Role
URL: https://github.com/apache/airflow/pull/4856
 
 
   
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-4028
   
   ### Description
   
   Currently Admin’s permissions will always be updated so it has ALL 
permissions, including each DAG’s “can_dag_view” and “can_dag_edit”.
   
   Let’s say we have 1000 DAGs now: then 2000 permissions will be added to 
Admin role in DB, and all of them will also be shown in UI if we go to 
Security->Roles.
   
   This may not be necessary as Admin role already has “can_dag_view” and 
“can_dag_edit” on special view “all_dags”.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Avoid Adding DAG_PERMS of All DAGs to Admin Role
> ------------------------------------------------
>
>                 Key: AIRFLOW-4028
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4028
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: webserver
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Minor
>
> Currently Admin’s permissions will always be updated so it has ALL 
> permissions, including each DAG’s “can_dag_view” and “can_dag_edit”.
> Let’s say we have 1000 DAGs now: then 2000 permissions will be added to Admin 
> role in DB, and all of them will also be shown in UI if we go to 
> Security->Roles.
> This may not be necessary as Admin role already has “can_dag_view” and 
> “can_dag_edit” on “all_dags”.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to