ashb commented on a change in pull request #4842: [AIRFLOW-4014] Change
DatastoreHook and add tests
URL: https://github.com/apache/airflow/pull/4842#discussion_r263003867
##########
File path: airflow/contrib/hooks/gcp_api_base_hook.py
##########
@@ -131,7 +131,7 @@ def _get_access_token(self):
"""
return self._get_credentials().token
- def _authorize(self):
+ def authorize(self):
Review comment:
The protected/private is only a convention. I didn't think anything in
checks if the method starts with `_` does it?
`_foo` as a method to me as a python developer says "Don't call this
function form outside the class and have an easy ride when you upgrade"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
